-
Notifications
You must be signed in to change notification settings - Fork 2
CPP-2497 Support setting custom Hako environments in containerised-app
plugins
#936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stuff in the containerised app plugins looks good to me and this is a great improvement. The rest of the stuff makes sense but I'm not super familiar with these internals so you may also want Kara to take a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great and thoughtful implementation! Added some thoughts. Thank you
We want to allow additional Hako environments in the future, particularly because some apps will be deployed to their own environments. We still need to assume some standardised structure, however, so that we can infer the domain and region from their name.
This allows flexibility for when apps want to deploy to custom environments. We drop the old `multiregion` option as part of this change as it can now be better expressed by setting the `hakoProductionEnvironments` option, rather than carving out a special case for the ft-com environments. We could have preserved backwards-compatibility with this change – or even continued supporting the option – but it feels better to rip the bandage off now whilst not many apps have it set and to encourage one way of defining multiple environments.
b6da71f
to
cb9f26d
Compare
This is such a simple dependency that it makes sense to pin it to minimise our supply chain attack surface. Let's do the same for the monorepo package version too. Co-Authored-By: Olusola Oguntimehin <[email protected]>
This issue was highlighted when I imported a bad path in a schema entrypoint and the only error I got was that the options were bad in the given plugin but then 0 errors were reported from that plugin... Not helpful!
cb9f26d
to
402e06c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top work
Description
This allows flexibility for when apps want to deploy to custom environments.
We drop the old
multiregion
option as part of this change as it can now be better expressed by setting thehakoProductionEnvironments
option, rather than carving out a special case for the ft-com environments. We could have preserved backwards-compatibility with this change – or even continued supporting the option – but it feels better to rip the bandage off now whilst not many apps have it set and to encourage one way of defining multiple environments.Closes #892.
Checklist:
feat(circleci): add support for nightly workflows
,fix: set Heroku app name for staging apps too