Skip to content

CPP-2497 Support setting custom Hako environments in containerised-app plugins #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 20, 2025

Conversation

ivomurrell
Copy link
Contributor

Description

This allows flexibility for when apps want to deploy to custom environments.

We drop the old multiregion option as part of this change as it can now be better expressed by setting the hakoProductionEnvironments option, rather than carving out a special case for the ft-com environments. We could have preserved backwards-compatibility with this change – or even continued supporting the option – but it feels better to rip the bandage off now whilst not many apps have it set and to encourage one way of defining multiple environments.

Closes #892.

Checklist:

  • My branch has been rebased onto the latest commit on main (don't merge main into your branch)
  • My commit messages are conventional commits, for example: feat(circleci): add support for nightly workflows, fix: set Heroku app name for staging apps too

@ivomurrell ivomurrell requested a review from a team May 16, 2025 16:51
Copy link
Member

@rowanmanning rowanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stuff in the containerised app plugins looks good to me and this is a great improvement. The rest of the stuff makes sense but I'm not super familiar with these internals so you may also want Kara to take a look?

Copy link
Contributor

@olusoladavid olusoladavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and thoughtful implementation! Added some thoughts. Thank you

We want to allow additional Hako environments in the future,
particularly because some apps will be deployed to their own
environments. We still need to assume some standardised structure,
however, so that we can infer the domain and region from their name.
This allows flexibility for when apps want to deploy to custom
environments.

We drop the old `multiregion` option as part of this change as it can
now be better expressed by setting the `hakoProductionEnvironments`
option, rather than carving out a special case for the ft-com
environments. We could have preserved backwards-compatibility with this
change – or even continued supporting the option – but it feels better
to rip the bandage off now whilst not many apps have it set and to
encourage one way of defining multiple environments.
@ivomurrell ivomurrell force-pushed the custom-hako-environments branch from b6da71f to cb9f26d Compare May 20, 2025 10:00
ivomurrell and others added 3 commits May 20, 2025 11:42
This is such a simple dependency that it makes sense to pin it to
minimise our supply chain attack surface. Let's do the same for the
monorepo package version too.

Co-Authored-By: Olusola Oguntimehin <[email protected]>
This issue was highlighted when I imported a bad path in a schema
entrypoint and the only error I got was that the options were bad in the
given plugin but then 0 errors were reported from that plugin... Not
helpful!
@ivomurrell ivomurrell force-pushed the custom-hako-environments branch from cb9f26d to 402e06c Compare May 20, 2025 10:42
Copy link
Member

@rowanmanning rowanmanning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Contributor

@olusoladavid olusoladavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top work

@ivomurrell ivomurrell merged commit 402e06c into main May 20, 2025
17 checks passed
@ivomurrell ivomurrell deleted the custom-hako-environments branch May 20, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configurable environments in containerised-app plugins
3 participants